lkml.org 
[lkml]   [2018]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 38/86] Input: xpad - remove unused function
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit a6ed4a18ba6a6f5a01e024b9d221d6439bf6ca4c ]

    There are two definitions of xpad_identify_controller(), one is used
    when CONFIG_JOYSTICK_XPAD_LEDS is set, but the other one is empty
    and never used, and we get a gcc warning about it:

    drivers/input/joystick/xpad.c:1210:13: warning: 'xpad_identify_controller' defined but not used [-Wunused-function]

    This removes the second definition.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Fixes: cae705baa40b ("Input: xpad - re-send LED command on present event")
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/input/joystick/xpad.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
    index 2f481ce2c8b0..cd1de2851f1d 100644
    --- a/drivers/input/joystick/xpad.c
    +++ b/drivers/input/joystick/xpad.c
    @@ -1209,7 +1209,6 @@ static void xpad_led_disconnect(struct usb_xpad *xpad)
    #else
    static int xpad_led_probe(struct usb_xpad *xpad) { return 0; }
    static void xpad_led_disconnect(struct usb_xpad *xpad) { }
    -static void xpad_identify_controller(struct usb_xpad *xpad) { }
    #endif

    static int xpad_start_input(struct usb_xpad *xpad)
    --
    2.17.1


    \
     
     \ /
      Last update: 2018-11-29 15:59    [W:4.424 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site