lkml.org 
[lkml]   [2018]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 072/110] scsi: hisi_sas: Remove set but not used variable dq_list
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit e34ff8edcae89922d187425ab0b82e6a039aa371 ]

    Fixes gcc '-Wunused-but-set-variable' warning:

    drivers/scsi/hisi_sas/hisi_sas_v1_hw.c: In function 'start_delivery_v1_hw':
    drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:907:20: warning:
    variable 'dq_list' set but not used [-Wunused-but-set-variable]

    drivers/scsi/hisi_sas/hisi_sas_v2_hw.c: In function 'start_delivery_v2_hw':
    drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:1671:20: warning:
    variable 'dq_list' set but not used [-Wunused-but-set-variable]

    drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function 'start_delivery_v3_hw':
    drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:889:20: warning:
    variable 'dq_list' set but not used [-Wunused-but-set-variable]

    It never used since introduction in commit
    fa222db0b036 ("scsi: hisi_sas: Don't lock DQ for complete task sending")

    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Acked-by: John Garry <john.garry@huawei.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 2 --
    drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 2 --
    drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 2 --
    3 files changed, 6 deletions(-)

    diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
    index 8f60f0e04599..410eccf0bc5e 100644
    --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
    +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
    @@ -904,11 +904,9 @@ static void start_delivery_v1_hw(struct hisi_sas_dq *dq)
    {
    struct hisi_hba *hisi_hba = dq->hisi_hba;
    struct hisi_sas_slot *s, *s1, *s2 = NULL;
    - struct list_head *dq_list;
    int dlvry_queue = dq->id;
    int wp;

    - dq_list = &dq->list;
    list_for_each_entry_safe(s, s1, &dq->list, delivery) {
    if (!s->ready)
    break;
    diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
    index 9c5c5a601332..1c4ea58da1ae 100644
    --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
    +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
    @@ -1666,11 +1666,9 @@ static void start_delivery_v2_hw(struct hisi_sas_dq *dq)
    {
    struct hisi_hba *hisi_hba = dq->hisi_hba;
    struct hisi_sas_slot *s, *s1, *s2 = NULL;
    - struct list_head *dq_list;
    int dlvry_queue = dq->id;
    int wp;

    - dq_list = &dq->list;
    list_for_each_entry_safe(s, s1, &dq->list, delivery) {
    if (!s->ready)
    break;
    diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
    index 08b503e274b8..687ff61bba9f 100644
    --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
    +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
    @@ -883,11 +883,9 @@ static void start_delivery_v3_hw(struct hisi_sas_dq *dq)
    {
    struct hisi_hba *hisi_hba = dq->hisi_hba;
    struct hisi_sas_slot *s, *s1, *s2 = NULL;
    - struct list_head *dq_list;
    int dlvry_queue = dq->id;
    int wp;

    - dq_list = &dq->list;
    list_for_each_entry_safe(s, s1, &dq->list, delivery) {
    if (!s->ready)
    break;
    --
    2.17.1


    \
     
     \ /
      Last update: 2018-11-29 15:37    [W:4.046 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site