Messages in this thread | | | Date | Tue, 27 Nov 2018 13:26:18 -0500 | From | Steven Rostedt <> | Subject | Re: [for-next][PATCH 04/18] arm64: function_graph: Simplify with function_graph_entry() |
| |
On Tue, 27 Nov 2018 18:07:23 +0000 Will Deacon <will.deacon@arm.com> wrote:
> On Wed, Nov 21, 2018 at 07:28:05PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org> > > > > The function_graph_entry() function does the work of calling the function > > graph hook function and the management of the shadow stack, simplifying the > > work done in the architecture dependent prepare_ftrace_return(). > > > > Have arm64 use the new code, and remove the shadow stack management as well as > > having to set up the trace structure. > > > > This is needed to prepare for a fix of a design bug on how the curr_ret_stack > > is used. > > > > Cc: Catalin Marinas <catalin.marinas@arm.com> > > Cc: Will Deacon <will.deacon@arm.com> > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: stable@kernel.org > > Fixes: 03274a3ffb449 ("tracing/fgraph: Adjust fgraph depth before calling trace return callback") > > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > --- > > arch/arm64/kernel/ftrace.c | 15 +-------------- > > 1 file changed, 1 insertion(+), 14 deletions(-) > > Minor nit: the subject refers to function_graph_entry(), but looks like > you settled on function_graph_enter() in the end.
Ah you're right!
> > Anyway, looks like no change for us, so: > > Acked-by: Will Deacon <will.deacon@arm.com>
Thanks!
-- Steve
| |