Messages in this thread | | | Date | Tue, 27 Nov 2018 12:12:44 +0000 | From | Will Deacon <> | Subject | Re: [PATCH v4 4/5] lib/ioremap: Ensure phys_addr actually corresponds to a physical address |
| |
On Mon, Nov 26, 2018 at 11:00:10AM -0800, Sean Christopherson wrote: > On Mon, Nov 26, 2018 at 05:07:46PM +0000, Will Deacon wrote: > > The current ioremap() code uses a phys_addr variable at each level of > > page table, which is confusingly offset by subtracting the base virtual > > address being mapped so that adding the current virtual address back on > > when iterating through the page table entries gives back the corresponding > > physical address. > > > > This is fairly confusing and results in all users of phys_addr having to > > add the current virtual address back on. Instead, this patch just updates > > phys_addr when iterating over the page table entries, ensuring that it's > > always up-to-date and doesn't require explicit offsetting. > > > > Cc: Chintan Pandya <cpandya@codeaurora.org> > > Cc: Toshi Kani <toshi.kani@hpe.com> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Michal Hocko <mhocko@suse.com> > > Cc: Andrew Morton <akpm@linux-foundation.org> > > Cc: Sean Christopherson <sean.j.christopherson@intel.com> > > Signed-off-by: Will Deacon <will.deacon@arm.com> > > Tested-by: Sean Christopherson <sean.j.christopherson@intel.com> > Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
Thanks, Sean. I think Andrew can queue these now.
Will
| |