lkml.org 
[lkml]   [2018]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/2] perf tests: Check for ARM [vectors] page
On Thu, Oct 25, 2018 at 10:55:06AM -0700, Florian Fainelli wrote:
> Hi all,
>
> I just painfully learned that perf would segfault when
> CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of
> it. This patch series adds an ARM test for that by leveraging the
> existing find_vdso_map() function and making it more generic and capable
> of location any map within /proc/self/maps.
>
> Changes in v2:
>
> - use strlen() instead of sizeof() -1 since we made the page name a
> parameter
> - use TEST_OK/TEST_FAIL in lieu of 0/-1
> - added an error message indicating CONFIG_KUSER_HELPERS might be
> disabled

other than the function placing I mentioned in
my previous email, this seems ok to me

jirka

>
> Florian Fainelli (2):
> perf tools: Make find_vdso_map() more modular
> perf tests: Add a test for the ARM 32-bit [vectors] page
>
> tools/perf/arch/arm/tests/Build | 1 +
> tools/perf/arch/arm/tests/arch-tests.c | 4 +++
> tools/perf/arch/arm/tests/vectors-page.c | 24 ++++++++++++++++++
> tools/perf/tests/tests.h | 5 ++++
> tools/perf/util/find-map.c | 31 ++++++++++++++++++++++++
> tools/perf/util/find-vdso-map.c | 30 +++--------------------
> 6 files changed, 68 insertions(+), 27 deletions(-)
> create mode 100644 tools/perf/arch/arm/tests/vectors-page.c
> create mode 100644 tools/perf/util/find-map.c
>
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2018-11-27 10:33    [W:0.073 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site