Messages in this thread | | | From | Dan Williams <> | Date | Mon, 26 Nov 2018 18:21:33 -0800 | Subject | Re: [driver-core PATCH v6 9/9] libnvdimm: Schedule device registration on node local to the device |
| |
On Thu, Nov 8, 2018 at 10:07 AM Alexander Duyck <alexander.h.duyck@linux.intel.com> wrote: > > Force the device registration for nvdimm devices to be closer to the actual > device. This is achieved by using either the NUMA node ID of the region, or > of the parent. By doing this we can have everything above the region based > on the region, and everything below the region based on the nvdimm bus. > > By guaranteeing NUMA locality I see an improvement of as high as 25% for > per-node init of a system with 12TB of persistent memory. >
It seems the speed-up is achieved with just patches 1, 2, and 9 from this series, correct? I wouldn't want to hold up that benefit while the driver-core bits are debated.
You can add:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
...if the series needs to be kept together, but as far as I can see the workqueue changes enable 2 sub-topics of development and it might make sense for Tejun to take those first 2 and then Greg and I can base any follow-up topics on that stable baseline.
| |