Messages in this thread | | | Subject | Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE | From | Anshuman Khandual <> | Date | Mon, 26 Nov 2018 19:32:44 +0530 |
| |
On 11/26/2018 06:18 PM, David Hildenbrand wrote: > On 26.11.18 13:26, Anshuman Khandual wrote: >> At present there are multiple places where invalid node number is encoded >> as -1. Even though implicitly understood it is always better to have macros >> in there. Replace these open encodings for an invalid node number with the >> global macro NUMA_NO_NODE. This helps remove NUMA related assumptions like >> 'invalid node' from various places redirecting them to a common definition. >> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> --- >> Changes in V2: >> >> - Added inclusion of 'numa.h' header at various places per Andrew >> - Updated 'dev_to_node' to use NUMA_NO_NODE instead per Vinod > > Reviewed-by: David Hildenbrand <david@redhat.com>
Thanks David. My bad, forgot to add your review tag from the earlier version.
| |