lkml.org 
[lkml]   [2018]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 097/118] RISC-V: Fix raw_copy_{to,from}_user()
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Olof Johansson <olof@lixom.net>

    commit 21f70d4abf9e17c2e3d7e64b7bfa3424e017f176 upstream.

    Sparse highlighted it, and appears to be a pure bug (from vs to).

    ./arch/riscv/include/asm/uaccess.h:403:35: warning: incorrect type in argument 1 (different address spaces)
    ./arch/riscv/include/asm/uaccess.h:403:39: warning: incorrect type in argument 2 (different address spaces)
    ./arch/riscv/include/asm/uaccess.h:409:37: warning: incorrect type in argument 1 (different address spaces)
    ./arch/riscv/include/asm/uaccess.h:409:41: warning: incorrect type in argument 2 (different address spaces)

    Signed-off-by: Olof Johansson <olof@lixom.net>
    Cc: stable@vger.kernel.org
    Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/riscv/include/asm/uaccess.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/riscv/include/asm/uaccess.h
    +++ b/arch/riscv/include/asm/uaccess.h
    @@ -400,13 +400,13 @@ extern unsigned long __must_check __asm_
    static inline unsigned long
    raw_copy_from_user(void *to, const void __user *from, unsigned long n)
    {
    - return __asm_copy_to_user(to, from, n);
    + return __asm_copy_from_user(to, from, n);
    }

    static inline unsigned long
    raw_copy_to_user(void __user *to, const void *from, unsigned long n)
    {
    - return __asm_copy_from_user(to, from, n);
    + return __asm_copy_to_user(to, from, n);
    }

    extern long strncpy_from_user(char *dest, const char __user *src, long count);

    \
     
     \ /
      Last update: 2018-11-26 12:08    [W:6.794 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site