lkml.org 
[lkml]   [2018]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT
On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote:
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -243,9 +243,20 @@ static int __init register_cpufreq_notifier(void)
> * until we have the necessary code to parse the cpu capacity, so
> * skip registering cpufreq notifier.
> */
> - if (!acpi_disabled || !raw_capacity)
> + if (!acpi_disabled)
> return -EINVAL;
>
> + if (!raw_capacity) {
> +
> + pr_info("cpu_capacity: No capacity defined in DT, set default "
> + "values to %ld\n", SCHED_CAPACITY_SCALE);

Why the extra blank line?

And what is userspace going to do with this noise? Is this an error?
Just normal operation? A device should never be saying anything to the
log for normal boot functionality. When is this called?

And no need for the "cpu_capacity:" right? Shouldn't the pr_info() line
handle the prefix for you?

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-11-26 16:07    [W:0.304 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site