Messages in this thread | | | Subject | Re: [PATCH 2/4] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE | From | Daniel Lezcano <> | Date | Fri, 23 Nov 2018 17:04:18 +0100 |
| |
On 23/11/2018 14:58, Sudeep Holla wrote: > On Mon, Oct 29, 2018 at 05:23:18PM +0100, Daniel Lezcano wrote: >> The mutex protects a per_cpu variable access. The potential race can >> happen only when the cpufreq governor module is loaded and at the same >> time the cpu capacity is changed in the sysfs. >> > > I wonder if we really need that sysfs entry to be writable. For some > reason, I had assumed it's read only, obviously it's not. I prefer to > make it RO if there's no strong reason other than debug purposes.
Are you suggesting to remove the READ_ONCE/WRITE_ONCE patch and set the sysfs file read-only ?
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |