Messages in this thread | | | Date | Thu, 22 Nov 2018 21:05:36 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v2] pwm: kconfig: enable kona pwm to be built for cygnus arch |
| |
Hello Clément,
On Wed, Nov 21, 2018 at 01:35:08PM +0100, Clément Péron wrote: > The Cygnus architecture use a Kona PWM. This is already present > in the device tree but can't be built actually. Hence, allow the > Kona PWM to be built for Cygnus arch. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > drivers/pwm/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index 27e5dd47a01f..982f4059f4e8 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -88,7 +88,9 @@ config PWM_BCM_IPROC > > config PWM_BCM_KONA > tristate "Kona PWM support" > - depends on ARCH_BCM_MOBILE > + depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST > + depends on HAVE_CLK && HAS_IOMEM > + default ARCH_BCM_CYGNUS
This looks good. As pointed out before the default is a bit strange and could include ARCH_BCM_MOBILE for symmetry.
Anyhow:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Related to this driver I have a set of questions: If the disable callback completed, does the hardware still drive the pin? If yes, would it be possible to disable the pin driver such that the pin gets high-Z? If yes, how?
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |