lkml.org 
[lkml]   [2018]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 08/10] staging: erofs: locked before registering for all new workgroups
From
Date
Hi Greg,

On 2018/11/22 18:24, Greg Kroah-Hartman wrote:
>> + /* lock all primary followed works before visible to others */
>> + if (unlikely(!mutex_trylock(&work->lock)))
>> + /* for a new workgroup, try_lock *never* fails */
>> + DBG_BUGON(1);
> Again, drop this, if it never fails, then there's no need for this. If
> it can fail, then properly handle it.
>
> And trylock can fail, so this needs to be fixed.

OK, I will drop this.

Thanks,
Gao Xiang

>
> thanks,

\
 
 \ /
  Last update: 2018-11-22 11:35    [W:0.053 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site