Messages in this thread | | | Date | Thu, 22 Nov 2018 09:29:51 +0000 | From | Charles Keepax <> | Subject | Re: [PATCH 11/11] mfd: wm8400-core: Make it explicitly non-modular |
| |
On Wed, Nov 21, 2018 at 11:32:59PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_WM8400 > drivers/mfd/Kconfig: bool "Wolfson Microelectronics WM8400" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Finally a function is renamed to remove word "module" in order to > possibly remove any confusion. > > Cc: Lee Jones <lee.jones@linaro.org> > Cc: patches@opensource.cirrus.com > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks, Charles
| |