| Date | Thu, 22 Nov 2018 09:45:26 +0100 | From | Maxime Ripard <> | Subject | Re: [RFC PATCH v3 09/17] pinctrl: sunxi: add support for suniv F1C100s (newer F-series SoCs) |
| |
Hi,
On Wed, Nov 21, 2018 at 09:30:42PM +0300, Mesih Kilinc wrote: > +static const struct sunxi_pinctrl_desc suniv_f1c100s_pinctrl_data = { > + .pins = suniv_f1c100s_pins, > + .npins = ARRAY_SIZE(suniv_f1c100s_pins), > + .irq_banks = 3, > + .disable_strict_mode = true, > +};
One thing I forgot to check before giving my Acked-by, you shouldn't disable the strict mode here, this is only meant as a legacy option, new drivers need to enforce it.
Maxime
-- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] |