lkml.org 
[lkml]   [2018]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: amd: add of_node_put()
From
Date
Hello!

On 21.11.2018 15:58, Yangtao Li wrote:

> of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it.

Again, maybe sparc_lance_probe_one() doesn't do that?

> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/net/ethernet/amd/sunlance.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/sunlance.c b/drivers/net/ethernet/amd/sunlance.c
> index b4fc0ed5bce8..9d4899826823 100644
> --- a/drivers/net/ethernet/amd/sunlance.c
> +++ b/drivers/net/ethernet/amd/sunlance.c
> @@ -1419,7 +1419,7 @@ static int sparc_lance_probe_one(struct platform_device *op,
>
> prop = of_get_property(nd, "tpe-link-test?", NULL);
> if (!prop)
> - goto no_link_test;
> + goto node_put;
>
> if (strcmp(prop, "true")) {
> printk(KERN_NOTICE "SunLance: warning: overriding option "
> @@ -1428,6 +1428,8 @@ static int sparc_lance_probe_one(struct platform_device *op,
> "to ecd@skynet.be\n");
> auxio_set_lte(AUXIO_LTE_ON);
> }
> +node_put:
> + of_node_put(nd);
> no_link_test:
> lp->auto_select = 1;
> lp->tpe = 0;

MBR, Sergei

\
 
 \ /
  Last update: 2018-11-22 09:30    [W:0.036 / U:1.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site