lkml.org 
[lkml]   [2018]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] procfs: fix the output format in /proc/PID/wchan
On Mon, 19 Nov 2018 19:17:52 +0800 Yafang Shao <laoar.shao@gmail.com> wrote:

> Just add the missing newline.
>
> ...
>
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -370,11 +370,12 @@ static int proc_pid_wchan(struct seq_file *m, struct pid_namespace *ns,
> wchan = get_wchan(task);
> if (wchan && !lookup_symbol_name(wchan, symname)) {
> seq_puts(m, symname);
> + seq_putc(m, '\n');
> return 0;
> }
>
> print0:
> - seq_putc(m, '0');
> + seq_puts(m, "0\n");
> return 0;
> }
> #endif /* CONFIG_KALLSYMS */

What is presently wrong with the wchan output? The changelog
should explain such things, please.

Providing example output with the patch unapplied and then with the
patch applied would help us to understand the patch's effect.

Thanks.

\
 
 \ /
  Last update: 2018-11-22 04:29    [W:0.043 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site