lkml.org 
[lkml]   [2018]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 15/42] net/sched: act_pedit: fix memory leak when IDR allocation fails
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Davide Caratti <dcaratti@redhat.com>

    [ Upstream commit 19ab69107d3ecfb7cd3e38ad262a881be40c01a3 ]

    tcf_idr_check_alloc() can return a negative value, on allocation failures
    (-ENOMEM) or IDR exhaustion (-ENOSPC): don't leak keys_ex in these cases.

    Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action")
    Signed-off-by: Davide Caratti <dcaratti@redhat.com>
    Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/act_pedit.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/net/sched/act_pedit.c
    +++ b/net/sched/act_pedit.c
    @@ -201,7 +201,8 @@ static int tcf_pedit_init(struct net *ne
    goto out_release;
    }
    } else {
    - return err;
    + ret = err;
    + goto out_free;
    }

    p = to_pedit(*a);

    \
     
     \ /
      Last update: 2018-11-21 20:09    [W:9.139 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site