Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 22 Nov 2018 15:19:45 +0100 | Subject | Re: [PATCH v2] regulator: wm8994: Don't use devres for enable GPIOs |
| |
On Wed, Nov 21, 2018 at 11:13 AM Charles Keepax <ckeepax@opensource.cirrus.com> wrote:
> The regulator core takes over managing the lifetime of the enable GPIO > once the regulator is registered. As such we shouldn't register the > enable GPIO using devm, or it will be freed twice. > > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks for fixing everything I break, I owe you big time Charles!
Now as Marek points out, I need to discern the pattern in this so I can see if I broke something else the same way.
Yours, Linus Walleij
| |