lkml.org 
[lkml]   [2018]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next v2 1/4] enetc: Introduce basic PF and VF ENETC ethernet drivers
Date
>-----Original Message-----
>From: David Miller <davem@davemloft.net>
>Sent: Thursday, November 22, 2018 2:21 AM
>To: Claudiu Manoil <claudiu.manoil@nxp.com>
>Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Alexandru
>Marginean <alexandru.marginean@nxp.com>; Catalin Horghidan
><catalin.horghidan@nxp.com>
>Subject: Re: [PATCH net-next v2 1/4] enetc: Introduce basic PF and VF ENETC
>ethernet drivers
>
>From: Claudiu Manoil <claudiu.manoil@nxp.com>
>Date: Tue, 20 Nov 2018 20:15:31 +0200
>
>> diff --git a/drivers/net/ethernet/freescale/Makefile
>b/drivers/net/ethernet/freescale/Makefile
>> index 3b4ff08..20e5c2f9 100644
>> --- a/drivers/net/ethernet/freescale/Makefile
>> +++ b/drivers/net/ethernet/freescale/Makefile
>> @@ -23,3 +23,4 @@ obj-$(CONFIG_FSL_FMAN) += fman/
>> obj-$(CONFIG_FSL_DPAA_ETH) += dpaa/
>>
>> obj-$(CONFIG_FSL_DPAA2_ETH) += dpaa2/
>> +obj-$(CONFIG_NET_VENDOR_FREESCALE) += enetc/
>
>The driver enable Kconfig option should guard traversing into the
>driver subdirectory, not the vendor enable Kconfig knob.

The enetc/ dir contains 2 drivers, that share a lot of common code.
Would you agree if I change the vendor enable with the two configs
(one for each driver) as below?

-obj-$(CONFIG_NET_VENDOR_FREESCALE) += enetc/
+obj-$(CONFIG_FSL_ENETC) += enetc/
+obj-$(CONFIG_FSL_ENETC_VF) += enetc/

Thanks,
Claudiu

\
 
 \ /
  Last update: 2018-11-22 14:06    [W:0.082 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site