Messages in this thread | | | Date | Tue, 20 Nov 2018 13:43:03 -0800 | From | Joel Fernandes <> | Subject | Re: [PATCH 2/8] pstore: Do not use crash buffer for decompression |
| |
On Wed, Nov 14, 2018 at 01:56:09AM -0600, Kees Cook wrote: > On Fri, Nov 2, 2018 at 1:24 PM, Joel Fernandes <joel@joelfernandes.org> wrote: > > On Thu, Nov 01, 2018 at 04:51:54PM -0700, Kees Cook wrote: > >> static void decompress_record(struct pstore_record *record) > >> { > >> + int ret; > >> int unzipped_len; > > > > nit: We could get rid of the unzipped_len variable now I think. > > I didn't follow this -- it gets used quite a bit. I don't see a clean > way to remove it?
You are right. Sorry I missed that crpyto_comp_decompress actually uses it.
thanks,
- Joel
| |