lkml.org 
[lkml]   [2018]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5] tpm: add support for partial reads
From
Date
On 11/20/18 4:48 AM, Jarkko Sakkinen wrote:
>> + /* Holds the resul of the last successful call to tpm_transmit() */
> This comment is cruft.

Do you want me to remove it? This is the comment you proposed.

>
>> + size_t response_length;
> data_pending would be now perfectly fine name now that we concluded
> that the original length is not needed to be stored. Better than this
> as once you decrease it the variable name and contents mismatch.
>

Can we finally agree on something? We have changed three times already.
response_length is exactly what it is and data_pending is a bit vague.

>> + /* Becomes true when the response (or part of it) is consumed */
>> + bool response_read;
> /* Tell whether response been consumed (read at least once). */
>
Ok I'll update the comment.

--
Tadeusz

\
 
 \ /
  Last update: 2018-11-20 19:37    [W:0.053 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site