Messages in this thread | | | From | NeilBrown <> | Date | Wed, 21 Nov 2018 15:58:53 +1100 | Subject | Re: [PATCH] staging: greybus: Parenthesis alignment |
| |
On Sun, Nov 18 2018, Joe Perches wrote:
> On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: >> Some parameters are aligned with parentheses. >> Some parentheses are opened at end of line. > > Given the very long identifier lengths, I wouldn't > consider many of these appropriate. > > 80 column line lengths and long identifiers don't > play well together. > >> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c > > [] >> @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec, >> i2s_port = 0; /* fixed for now */ >> cportid = data->connection->hd_cport_id; >> ret = gb_audio_apbridgea_register_cport(data->connection, >> - i2s_port, cportid, >> + i2s_port, cportid, >> AUDIO_APBRIDGEA_DIRECTION_TX);
My preferred formatting in this situation is
ret = gb_audio_apbridgea_register_cport( data->connection, i2s_port, cportid, AUDIO_APBRIDGEA_DIRECTION_TX);
but checkpatch doesn't like the '(' at the end of the line. Do you know why that is?
Thanks, NeilBrown
> > But if you are going to do this for multiple line > statements, please fix all the line continuations of > the statement, not just the first. > >> if (ret) { >> dev_err_ratelimited(module->dev, >> @@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id) >> i2s_port = 0; /* fixed for now */ >> cportid = data->connection->hd_cport_id; >> ret = gb_audio_apbridgea_unregister_cport(data->connection, >> - i2s_port, cportid, >> + i2s_port, cportid, >> AUDIO_APBRIDGEA_DIRECTION_TX); > > etc... [unhandled content-type:application/pgp-signature] | |