lkml.org 
[lkml]   [2018]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 2/4] ARM: tegra: Fix DRAM refresh-interval clobbering on resume from LP1 on Tegra30
From
Date

On 30/08/2018 19:54, Dmitry Osipenko wrote:
> The DRAM refresh-interval is getting erroneously set to "1" on exiting
> from memory self-refreshing mode. The clobbered interval causes the
> "refresh request overflow timeout" error raised by the External Memory
> Controller on exiting from LP1 on Tegra30.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> arch/arm/mach-tegra/sleep-tegra30.S | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/sleep-tegra30.S b/arch/arm/mach-tegra/sleep-tegra30.S
> index 801fe58978ae..99ac9c6dcf7c 100644
> --- a/arch/arm/mach-tegra/sleep-tegra30.S
> +++ b/arch/arm/mach-tegra/sleep-tegra30.S
> @@ -29,7 +29,6 @@
> #define EMC_CFG 0xc
> #define EMC_ADR_CFG 0x10
> #define EMC_TIMING_CONTROL 0x28
> -#define EMC_REFRESH 0x70
> #define EMC_NOP 0xdc
> #define EMC_SELF_REF 0xe0
> #define EMC_MRW 0xe8
> @@ -459,7 +458,6 @@ emc_wait_auto_cal_onetime:
> cmp r10, #TEGRA30
> streq r1, [r0, #EMC_NOP]
> streq r1, [r0, #EMC_NOP]
> - streq r1, [r0, #EMC_REFRESH]
>
> emc_device_mask r1, r0

Acked-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

--
nvpublic

\
 
 \ /
  Last update: 2018-11-20 11:28    [W:0.156 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site