Messages in this thread | | | Date | Tue, 20 Nov 2018 11:29:43 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH 00/12] perf top: Rework processing code |
| |
Hi Jirka,
On Mon, Nov 19, 2018 at 01:20:04PM +0100, Jiri Olsa wrote: > hi, > David reported issues with perf top loosing side band events > so we moved mmap reading and hists processing into separated > threads. > > This patchset also adds dropping sample logic when the processing > falls behind the reader thread. This way we get incomplete but > current data in perf top. > > Also available in: > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > perf/fixes
Beside the simple comment in 05/12 (and the related fix), it looks good to me. And I think we can do similar for hists->lock as well.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
| |