lkml.org 
[lkml]   [2018]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes
Date
On 11/19/2018 12:21 PM, Thomas Gleixner wrote:
> On Fri, 16 Nov 2018, Tim Chen wrote:
>> +static enum spectre_v2_app2app_mitigation_cmd __init
>> + spectre_v2_parse_app2app_cmdline(enum spectre_v2_mitigation_cmd v2_cmd)
>> +{
>> + enum spectre_v2_app2app_mitigation_cmd cmd;
>> + char arg[20];
>> + int ret, i;
>> +
>> + if (v2_cmd == SPECTRE_V2_CMD_FORCE) {
>> + cmd = SPECTRE_V2_APP2APP_CMD_FORCE;
>> + goto show_cmd;
>
> What initializes 'i' in this case? Compiler warnings are overrated.

Will fix.

>
> What exactly handles the SPECTRE_V2_NONE case which you documented in the
> commandline bits?
>

The default spectre_v2_app2app_enabled is set to SPECTRE_V2_APP2APP_NONE.

When we have SPECTRE_V2_NONE case, we will have return in spectre_v2_select_mitigation
without calling spectre_v2_parse_app2app_cmdline. So we will have
SPECTRE_V2_APP2APP_NONE.

Tim

\
 
 \ /
  Last update: 2018-11-19 23:44    [W:0.251 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site