Messages in this thread | | | Subject | Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver | From | Marek Vasut <> | Date | Mon, 19 Nov 2018 23:10:04 +0100 |
| |
On 11/19/2018 04:27 PM, Mark Brown wrote: > On Mon, Nov 19, 2018 at 03:12:00PM +0100, Marek Vasut wrote: >> On 11/19/2018 11:01 AM, Mason Yang wrote: > >>> +++ b/drivers/spi/spi-renesas-rpc.c >>> @@ -0,0 +1,750 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +// >>> +// Copyright (C) 2018 ~ 2019 Renesas Solutions Corp. >>> +// Copyright (C) 2018 Macronix International Co., Ltd. >>> +// >>> +// R-Car D3 RPC SPI/QSPI/Octa driver >>> +// >>> +// Authors: >>> +// Mason Yang <masonccyang@mxic.com.tw> >>> +// > >> Fix multiline comment please. > > The SPDX header needs to be C++ style so I push people to make the whole > block C++ otherwise it looks messy.
OK, I'm not gonna wrestle you on this, but I think it looks horrible ;-)
-- Best regards, Marek Vasut
| |