Messages in this thread | | | Date | Thu, 1 Nov 2018 23:06:52 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 01/25] amd-gpu: Don't undefine READ and WRITE [ver #2] |
| |
On Wed 2018-10-24 00:57:50, David Howells wrote: > Remove the undefinition of READ and WRITE because these constants may be > used elsewhere in subsequently included header files, thus breaking them. > > These constants don't actually appear to be used in the driver, so the > undefinition seems pointless. > > Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc display driver (v2)") > Signed-off-by: David Howells <dhowells@redhat.com> > --- > > drivers/gpu/drm/amd/display/dc/os_types.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h b/drivers/gpu/drm/amd/display/dc/os_types.h > index a407892905af..c0d9f332baed 100644 > --- a/drivers/gpu/drm/amd/display/dc/os_types.h > +++ b/drivers/gpu/drm/amd/display/dc/os_types.h > @@ -40,8 +40,6 @@ > #define LITTLEENDIAN_CPU > #endif > > -#undef READ > -#undef WRITE > #undef FRAME_SIZE >
While you are at it... is undefining FRAME_SIZE good idea? It seems like this is another bug waiting to be discovered.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |