lkml.org 
[lkml]   [2018]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 089/150] net: ena: fix rare bug when failed restart/resume is followed by driver removal
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit d7703ddbd7c9cb1ab7c08e1b85b314ff8cea38e9 ]

    In a rare scenario when ena_device_restore() fails, followed by device
    remove, an FLR will not be issued. In this case, the device will keep
    sending asynchronous AENQ keep-alive events, even after driver removal,
    leading to memory corruption.

    Fixes: 8c5c7abdeb2d ("net: ena: add power management ops to the ENA driver")
    Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
    index 7093b661c50e..72dbdebf4b5d 100644
    --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
    +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
    @@ -2648,7 +2648,11 @@ err_disable_msix:
    ena_free_mgmnt_irq(adapter);
    ena_disable_msix(adapter);
    err_device_destroy:
    + ena_com_abort_admin_commands(ena_dev);
    + ena_com_wait_for_abort_completion(ena_dev);
    ena_com_admin_destroy(ena_dev);
    + ena_com_mmio_reg_read_request_destroy(ena_dev);
    + ena_com_dev_reset(ena_dev, ENA_REGS_RESET_DRIVER_INVALID_STATE);
    err:
    clear_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags);
    clear_bit(ENA_FLAG_ONGOING_RESET, &adapter->flags);
    --
    2.17.1


    \
     
     \ /
      Last update: 2018-11-02 20:06    [W:2.237 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site