Messages in this thread | | | Date | Fri, 2 Nov 2018 08:52:45 +0100 | From | jacopo mondi <> | Subject | Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning |
| |
Hi Randy, thanks for the patch.
On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > arch/sh/boards/mach-kfr2r09/setup.c does not need to #include > <mtd/onenand.h>, and doing so causes a build warning, so drop > that header file. > > In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28: > ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration > struct mtd_oob_ops *ops); > > Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
Not sure if this is worth pointing out, but this commit only resorts headers. The one introducing the warning is actually 33893d7aa.
I felt like reporting this, as introducing a "Fixes" line for that commit too would help backporting maybe?
In any case: Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks j
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > Cc: Rich Felker <dalias@libc.org> > Cc: Jacopo Mondi <jacopo+renesas@jmondi.org> > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: linux-mtd@lists.infradead.org > Cc: linux-sh@vger.kernel.org > --- > arch/sh/boards/mach-kfr2r09/setup.c | 1 - > 1 file changed, 1 deletion(-) > > --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c > +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c > @@ -25,7 +25,6 @@ > #include <linux/memblock.h> > #include <linux/mfd/tmio.h> > #include <linux/mmc/host.h> > -#include <linux/mtd/onenand.h> > #include <linux/mtd/physmap.h> > #include <linux/platform_data/lv5207lp.h> > #include <linux/platform_device.h> > > [unhandled content-type:application/pgp-signature] | |