lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 079/160] media: em28xx: make v4l2-compliance happier by starting sequence on zero
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

    commit afeaade90db4c5dab93f326d9582be1d5954a198 upstream.

    The v4l2-compliance tool complains if a video doesn't start
    with a zero sequence number.

    While this shouldn't cause any real problem for apps, let's
    make it happier, in order to better check the v4l2-compliance
    differences before and after patchsets.

    This is actually an old issue. It is there since at least its
    videobuf2 conversion, e. g. changeset 3829fadc461 ("[media]
    em28xx: convert to videobuf2"), if VB1 wouldn't suffer from
    the same issue.

    Cc: stable@vger.kernel.org
    Fixes: d3829fadc461 ("[media] em28xx: convert to videobuf2")
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/usb/em28xx/em28xx-video.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/media/usb/em28xx/em28xx-video.c
    +++ b/drivers/media/usb/em28xx/em28xx-video.c
    @@ -1149,6 +1149,8 @@ static void em28xx_ctrl_notify(struct v4
    {
    struct em28xx *dev = priv;

    + dev->v4l2->field_count = 0;
    +
    /*
    * In the case of non-AC97 volume controls, we still need
    * to do some setups at em28xx, in order to mute/unmute

    \
     
     \ /
      Last update: 2018-11-19 18:00    [W:4.016 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site