lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 108/205] mtd: spi-nor: cadence-quadspi: Return error code in cqspi_direct_read_execute()
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit 91d7b67000c6e9bd605624079fee5a084238ad92 upstream.

    We return 0 unconditionally in 'cqspi_direct_read_execute()'.
    However, 'ret' is set to some error codes in several error handling
    paths.

    Return 'ret' instead to propagate the error code.

    Fixes: ffa639e069fb ("mtd: spi-nor: cadence-quadspi: Add DMA support for direct mode reads")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/spi-nor/cadence-quadspi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mtd/spi-nor/cadence-quadspi.c
    +++ b/drivers/mtd/spi-nor/cadence-quadspi.c
    @@ -996,7 +996,7 @@ static int cqspi_direct_read_execute(str
    err_unmap:
    dma_unmap_single(nor->dev, dma_dst, len, DMA_DEV_TO_MEM);

    - return 0;
    + return ret;
    }

    static ssize_t cqspi_read(struct spi_nor *nor, loff_t from,

    \
     
     \ /
      Last update: 2018-11-19 17:37    [W:2.491 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site