Messages in this thread | | | Subject | Re: [PATCH 0/2] PCI/AER: Consistently use _OSC to determine who owns AER | From | Sinan Kaya <> | Date | Mon, 19 Nov 2018 12:42:25 -0500 |
| |
On 11/19/2018 12:32 PM, Sinan Kaya wrote: >> >> But we're not using HEST as a fine grain control. We disable native AER >> handling if *any* device has FF set in HEST, and that just forces people >> to use pcie_ports=native to get around that. >> > > I don't see *any* in the code. aer_hest_parse() does the HEST table parsing. > It switches to firmware first mode if global flag in HEST is set. Otherwise > for each BDF in device, hest_match_pci() is used to do a cross-matching against > HEST table contents. > > Am I missing something?
I see. I think you are talking about aer_firmware_first, right?
aer_set_firmware_first() and pcie_aer_get_firmware_first() seem to do the right thing.
aer_firmware_first is probably getting set because events are all routed to a single root port and aer_acpi_firmware_first() is used to decide whether AER should be initialized or not.
I think I understand what is going on now.
Still, breaking existing systems that rely on HEST table is not cool. I'd rather have users specify "pcie_ports=native" to skip FF rather than having broken systems by default to be honest.
| |