lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 054/205] scsi: qla2xxx: Fix early srb free on abort
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Quinn Tran <quinn.tran@cavium.com>

    commit 8235f4b5aeba868739f6e12a51ad92689e3f78ef upstream.

    Task abort can take 2 paths: 1) serial/synchronous abort where the calling
    thread will put to sleep, wait for completion and free cmd resource. 2) async
    abort where the cmd free will be free by the completion thread. For path 2,
    driver is freeing the SRB too early.

    Fixes: f6145e86d21f ("scsi: qla2xxx: Fix race between switch cmd completion and timeout")
    Cc: stable@vger.kernel.org # 4.19
    Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
    Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/qla2xxx/qla_init.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/scsi/qla2xxx/qla_init.c
    +++ b/drivers/scsi/qla2xxx/qla_init.c
    @@ -1788,6 +1788,8 @@ qla24xx_async_abort_cmd(srb_t *cmd_sp, b
    wait_for_completion(&abt_iocb->u.abt.comp);
    rval = abt_iocb->u.abt.comp_status == CS_COMPLETE ?
    QLA_SUCCESS : QLA_FUNCTION_FAILED;
    + } else {
    + goto done;
    }

    done_free_sp:

    \
     
     \ /
      Last update: 2018-11-19 19:06    [W:6.195 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site