Messages in this thread | | | From | NeilBrown <> | Date | Sun, 18 Nov 2018 08:33:03 +1100 | Subject | Re: [PATCH v6 1/3] staging: mt7621-mmc: Remove #if 0 blocks in sd.c |
| |
On Thu, Oct 04 2018, Nishad Kamdar wrote:
> This patch removes #if 0 code blocks and usages of > functions defined in the #if 0 blocks in sd.c. > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
Hi Nishad, thanks for this patch (and others) and apologies for not reviewing/testing it earlier. Unfortunately there is a problem - see below.
> > -#if 0 /* --- by chhung */ > -/* For E2 only */ > -static u8 clk_src_bit[4] = { > - 0, 3, 5, 7 > -}; > - > static void msdc_select_clksrc(struct msdc_host *host, unsigned char clksrc) > { > u32 val;
Above you removed the first few lines of a "#if 0" block, but not all of it. Previously the function msdc_select_clksrc() was not compiled at all. Now it is, and that causes an error - MSDC_CLKSRC_REG is not defined.
Would you be able to send a follow-patch patch which removes this function and the "#endif /* end of --- */" at the end?
Thanks, NeilBrown [unhandled content-type:application/pgp-signature] | |