Messages in this thread | | | Date | Sat, 17 Nov 2018 12:08:00 -0800 (PST) | Subject | Re: [PATCH net-next 1/4] enetc: Introduce basic PF and VF ENETC ethernet drivers | From | David Miller <> |
| |
From: Claudiu Manoil <claudiu.manoil@nxp.com> Date: Thu, 15 Nov 2018 18:13:53 +0200
> + if (!nr_frags && !(flags & ENETC_TXBD_FLAGS_EX)) > + flags |= ENETC_TXBD_FLAGS_F; > + > + txbd->flags = flags; > + > + if (flags & ENETC_TXBD_FLAGS_EX) { ... > + if (!nr_frags) ... > + } > + > + frag = &skb_shinfo(skb)->frags[0]; > + for (f = 0; f < nr_frags; f++, frag++) { ... > + } > + > + if (nr_frags) > + /* last BD needs 'F' bit set */ > + txbd->flags = ENETC_TXBD_FLAGS_F;
Isn't it so much simpler to just have an unconditional:
txbd->flags |= ENETC_TXBD_FLAGS_F;
at the end of this code segment?
Then all of this code conditional on nr_frags can go away.
| |