Messages in this thread | | | Date | Fri, 16 Nov 2018 17:06:22 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH] staging: greybus: arche-platform: Switch to the gpio descriptor interface |
| |
On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated > old non-descriptor interface. > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> > ---
Always include a change log here after the cut-off line so we know what changed since previous versions.
Also include the patch revision in the Subject (e.g. "[PATCH v3] staging: greybus: ...").
> drivers/staging/greybus/arche-platform.c | 120 ++++++++--------------- > 1 file changed, 42 insertions(+), 78 deletions(-) > > diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c > index 4c36e88766e7..a826a1835628 100644 > --- a/drivers/staging/greybus/arche-platform.c > +++ b/drivers/staging/greybus/arche-platform.c > @@ -8,10 +8,9 @@ > > #include <linux/clk.h> > #include <linux/delay.h> > -#include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/init.h> > #include <linux/module.h> > -#include <linux/of_gpio.h> > #include <linux/of_platform.h> > #include <linux/pinctrl/consumer.h> > #include <linux/platform_device.h> > @@ -45,14 +44,15 @@ enum svc_wakedetect_state { > > struct arche_platform_drvdata { > /* Control GPIO signals to and from AP <=> SVC */ > - int svc_reset_gpio; > + struct gpio_desc *svc_reset; > + struct gpio_desc *svc_sysboot; > bool is_reset_act_hi; > - int svc_sysboot_gpio; > - int wake_detect_gpio; /* bi-dir,maps to WAKE_MOD & WAKE_FRAME signals */ > + struct gpio_desc *wake_detect; > + /* bi-dir,maps to WAKE_MOD & WAKE_FRAME signals */
I'm not commenting on the rest, but comments never go underneath what they apply to.
Just keep the current comment here, even if it's placement is a bit odd and makes the line be longer than 80 cols.
Johan
| |