lkml.org 
[lkml]   [2018]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()
From
Date


On 11/16/2018 11:47 AM, Petr Tesarik wrote:
> The driver uses test_facility(), but does not include the
> corresponding include file explicitly. The driver currently builds
> only thanks to the following include chain:
>
> vfio_ap_drv.c
> <linux/module.h>
> <linux/elf.h>
> <asm/elf.h>
> <linux/compat.h>
> <asm/uaccess.h>
> <asm/facility.h>
>
> Files should not rely on such fragile implicit includes.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>

Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>

> ---
> drivers/s390/crypto/vfio_ap_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 7667b38728f0..31c6c847eaca 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -11,6 +11,7 @@
> #include <linux/mod_devicetable.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <asm/facility.h>
> #include "vfio_ap_private.h"
>
> #define VFIO_AP_ROOT_NAME "vfio_ap"
>

\
 
 \ /
  Last update: 2018-11-16 12:51    [W:0.044 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site