Messages in this thread | | | Subject | Re: [PATCH v2] media: venus: dynamic handling of bitrate | From | Stanimir Varbanov <> | Date | Thu, 15 Nov 2018 11:19:12 +0200 |
| |
Hi Malathi,
Thanks for the patch!
On 11/2/18 2:41 PM, Malathi Gottam wrote: > Any request for a change in bitrate after both planes > are streamed on is handled by setting the target bitrate > property to hardware. > > Signed-off-by: Malathi Gottam <mgottam@codeaurora.org> > --- > drivers/media/platform/qcom/venus/venc_ctrls.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+)
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> > diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c b/drivers/media/platform/qcom/venus/venc_ctrls.c > index 45910172..f90a34e 100644 > --- a/drivers/media/platform/qcom/venus/venc_ctrls.c > +++ b/drivers/media/platform/qcom/venus/venc_ctrls.c > @@ -79,7 +79,9 @@ static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl) > { > struct venus_inst *inst = ctrl_to_inst(ctrl); > struct venc_controls *ctr = &inst->controls.enc; > + struct hfi_bitrate brate; > u32 bframes; > + u32 ptype; > int ret; > > switch (ctrl->id) { > @@ -88,6 +90,19 @@ static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl) > break; > case V4L2_CID_MPEG_VIDEO_BITRATE: > ctr->bitrate = ctrl->val; > + mutex_lock(&inst->lock); > + if (inst->streamon_out && inst->streamon_cap) { > + ptype = HFI_PROPERTY_CONFIG_VENC_TARGET_BITRATE; > + brate.bitrate = ctr->bitrate; > + brate.layer_id = 0; > + > + ret = hfi_session_set_property(inst, ptype, &brate); > + if (ret) { > + mutex_unlock(&inst->lock); > + return ret; > + } > + } > + mutex_unlock(&inst->lock); > break; > case V4L2_CID_MPEG_VIDEO_BITRATE_PEAK: > ctr->bitrate_peak = ctrl->val; >
-- regards, Stan
| |