Messages in this thread | | | From | Julien Freche <> | Subject | Re: [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline | Date | Thu, 15 Nov 2018 01:42:30 +0000 |
| |
>On 11/14/18, 3:41 PM, "Nadav Amit" <namit@vmware.com> wrote: >>From: David Hildenbrand >>Sent: November 14, 2018 at 11:05:38 PM GMT >> Subject: Re: [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline >> >> >> Can you share if something like this is also desired for vmware's >> implementation? (I tagged this as RFC to get some more feedback) >> >> It should in theory be as simple as adding a handful of >> _SetPageOffline()/_ClearPageOffline() at the right spots. > > Thanks, I was just suspecting it is personal ;-) > > I would obviously prefer that your changes would be done on top of those > that were skipped. This patch-set sounds very reasonable to me, but I prefer > that Julien (cc’d) would also give his opinion.
I think this is desirable for VMware's implementation also. You are right, dumping data that is not relevant is a waste :-) I haven't heard of any panic/issue due to this but that's still a good optimization.
Nadav or I could help to test that on ESX if required.
Regards,
-- Julien Freche
| |