Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH 2/2] drm/msm/dsi: Get PHY ref clock from the DT | Date | Wed, 14 Nov 2018 15:30:36 -0800 |
| |
Quoting Matthias Kaehlcke (2018-11-14 14:24:43) > On Tue, Nov 06, 2018 at 03:11:48PM -0800, Stephen Boyd wrote: > > Quoting Matthias Kaehlcke (2018-11-02 14:45:34) > > > @@ -630,7 +632,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm) > > > char clk_name[32], parent[32], vco_name[32]; > > > char parent2[32], parent3[32], parent4[32]; > > > struct clk_init_data vco_init = { > > > - .parent_names = (const char *[]){ "xo" }, > > > + .parent_names = (const char *[]){ > > > + __clk_get_name(pll_10nm->vco_ref_clk) }, > > > > I find this syntax odd, in addition to needing to check for NULL here as > > Sean pointed out. Preferably just have it be the address of the > > character pointer instead of making an anonymous array and then casting > > that inline, i.e > > > > .parent_names = &ref_clk_name, > > Ok > > I'm not convinced the check for NULL is needed though, see my reply to Sean.
Ok! I'm fine either way on the NULL stuff.
| |