lkml.org 
[lkml]   [2018]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.18 43/59] ice: Fix dead device link issue with flow control
    Date
    From: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>

    [ Upstream commit 0f5d4c21a50716f8bd4e220544b82dca7408d113 ]

    Setting Rx or Tx pause parameter currently results in link loss on the
    interface, requiring the platform/host to be cold power cycled. Fix it.

    Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
    Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
    Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
    index c71a9b528d6d..0717d2e1ab67 100644
    --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
    +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
    @@ -786,10 +786,15 @@ ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause)
    }

    if (!test_bit(__ICE_DOWN, pf->state)) {
    - /* Give it a little more time to try to come back */
    + /* Give it a little more time to try to come back. If still
    + * down, restart autoneg link or reinitialize the interface.
    + */
    msleep(75);
    if (!test_bit(__ICE_DOWN, pf->state))
    return ice_nway_reset(netdev);
    +
    + ice_down(vsi);
    + ice_up(vsi);
    }

    return err;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-11-14 23:36    [W:5.541 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site