lkml.org 
[lkml]   [2018]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v11 3/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdlien from kexec
    On Tue, Nov 13, 2018 at 06:54:13PM +0100, Borislav Petkov wrote:
    > On Tue, Nov 13, 2018 at 11:11:11AM -0500, Masayoshi Mizuma wrote:
    > > I think it's not very good idea to use kstrtoull() in
    > > arch/x86/boot/compressed/* because some tricks are needed to
    > > use the function, looks like Chao is trying...
    >
    > Ok, I had a look at the patch. And frankly, I don't see anything wrong
    > with the aspect of using kstrtoull() in the compressed stage too and
    > getting rid of simple_strtoull().
    >
    > So what are your reservations?

    Thank you for your checking.
    I just felt the BOOT_STRING thing in lib/kstrtox.c confuses...
    I'm OK for now if it's applied your below comment.

    > > @@ -126,6 +126,8 @@ int kstrtoull(const char *s, unsigned int base, unsigned long long *res)
    > > }
    > > EXPORT_SYMBOL(kstrtoull);
    >
    > This needs a comment to explain what is that guard used for.

    Thanks,
    Masa

    \
     
     \ /
      Last update: 2018-11-13 21:07    [W:6.423 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site