Messages in this thread | | | Date | Mon, 12 Nov 2018 16:26:44 -0800 (PST) | Subject | Re: [PATCH][net-next] net: phy: check if advertising is zero using linkmode_empty | From | David Miller <> |
| |
From: Colin King <colin.king@canonical.com> Date: Mon, 12 Nov 2018 23:45:56 +0000
> From: Colin Ian King <colin.king@canonical.com> > > A recent change modified variable advertising from a u32 to a link mode > array and left the u32 zero comparison, so essential we now have an array > being compared to null which is not the intention. Fix this by using the > call to linkmode_empty to check if advertising is all zero. > > Detected by CoverityScan, CID#1475424 ("Array compared against 0") > > Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
| |