Messages in this thread | | | From | Nadav Amit <> | Subject | Re: [PATCH v4 09/10] x86/jump-label: remove support for custom poker | Date | Sun, 11 Nov 2018 20:31:29 +0000 |
| |
From: Peter Zijlstra Sent: November 11, 2018 at 3:05:53 PM GMT > To: Nadav Amit <namit@vmware.com> > Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org, x86@kernel.org, H. Peter Anvin <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski <luto@kernel.org>, Kees Cook <keescook@chromium.org>, Dave Hansen <dave.hansen@intel.com>, Masami Hiramatsu <mhiramat@kernel.org> > Subject: Re: [PATCH v4 09/10] x86/jump-label: remove support for custom poker > > > On Sat, Nov 10, 2018 at 03:17:31PM -0800, Nadav Amit wrote: >> There are only two types of poking: early and breakpoint based. The use >> of a function pointer to perform poking complicates the code and is >> probably inefficient due to the use of indirect branches. > > Right; we used to have a 3rd way, but that is long gone. > > Nice cleanup!
Thanks, but I actually should have got rid of the early_poking variable. I will do it for v5.
| |