Messages in this thread | | | Subject | Re: [PATCH] scsi: libsas: Remove pcidev reference | From | John Garry <> | Date | Mon, 12 Nov 2018 17:55:19 +0000 |
| |
On 12/11/2018 17:49, John Garry wrote: > On 12/11/2018 17:32, Joe Perches wrote: >> On Tue, 2018-11-13 at 01:28 +0800, John Garry wrote: >>> Not all host drivers are PCI drivers - like hisi_sas, which supports a >>> platform driver - so remove reference to "pcidev". >>> >>> The debug level is also downgraded to KERN_ERR for the same message. >> [] >>> diff --git a/drivers/scsi/libsas/sas_discover.c >>> b/drivers/scsi/libsas/sas_discover.c >> [] >>> @@ -186,7 +186,7 @@ int sas_notify_lldd_dev_found(struct >>> domain_device *dev) >>> >>> res = i->dft->lldd_dev_found(dev); >>> if (res) { >>> - printk("sas: driver on pcidev %s cannot handle " >>> + pr_err("sas: driver on host %s cannot handle " >>> "device %llx, error:%d\n", >> >> As a printk without a KERN_<LEVEL> is printed at whatever >> CONFIG_MESSAGE_LOGLEVEL_DEFAULT is set to (default: 4 and >> rarely unchanged), this is effectively upgraded from a >> KERN_WARNING to KERN_ERR. > > ah, I thought that it was printed always. > > So maybe I'll just leave as-is.
I forgot to mention that checkpatch complains about using printk() - that's why I changed it.
Thanks, John
> >> >> >> >> . >> > > > > . >
| |