Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 12 Nov 2018 10:42:47 +0100 | Subject | Re: [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller |
| |
Hi Carmeli,
CC Magnus
(staging drivers receive so may janitorial changes that the original author is lost in the git shortlog noise)
On Wed, Nov 7, 2018 at 9:46 PM Carmeli Tamir <carmeli.tamir@gmail.com> wrote: > Added static modifier to the udc_controller, since it's only > required within emxx_udc.c. > > Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
Thanks for your patch!
> --- a/drivers/staging/emxx_udc/emxx_udc.c > +++ b/drivers/staging/emxx_udc/emxx_udc.c > @@ -56,7 +56,7 @@ static void _nbu2ss_fifo_flush(struct nbu2ss_udc *, struct nbu2ss_ep *); > > /*===========================================================================*/ > /* Global */ > -struct nbu2ss_udc udc_controller; > +static struct nbu2ss_udc udc_controller;
What about the "Global" comment? Perhaps this was intentional?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |