Messages in this thread | | | Date | Mon, 12 Nov 2018 09:15:18 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH v2] exec: make de_thread() freezable |
| |
On 11/12, Chanho Min wrote: > > @@ -1083,7 +1084,7 @@ static int de_thread(struct task_struct *tsk) > while (sig->notify_count) { > __set_current_state(TASK_KILLABLE); > spin_unlock_irq(lock); > - schedule(); > + freezable_schedule(); > if (unlikely(__fatal_signal_pending(tsk))) > goto killed; > spin_lock_irq(lock); > @@ -1111,7 +1112,7 @@ static int de_thread(struct task_struct *tsk) > __set_current_state(TASK_KILLABLE); > write_unlock_irq(&tasklist_lock); > cgroup_threadgroup_change_end(tsk); > - schedule(); > + freezable_schedule(); > if (unlikely(__fatal_signal_pending(tsk))) > goto killed; > }
Thanks, looks good to me.
Acked-by: Oleg Nesterov <oleg@redhat.com>
| |