lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 133/361] f2fs: fix to account IO correctly for cgroup writeback
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Chao Yu <yuchao0@huawei.com>

    [ Upstream commit 78efac537de33faab9a4302cc05a70bb4a8b3b63 ]

    Now, we have supported cgroup writeback, it depends on correctly IO
    account of specified filesystem.

    But in commit d1b3e72d5490 ("f2fs: submit bio of in-place-update pages"),
    we split write paths from f2fs_submit_page_mbio() to two:
    - f2fs_submit_page_bio() for IPU path
    - f2fs_submit_page_bio() for OPU path

    But still we account write IO only in f2fs_submit_page_mbio(), result in
    incorrect IO account, fix it by adding missing IO account in IPU path.

    Fixes: d1b3e72d5490 ("f2fs: submit bio of in-place-update pages")
    Signed-off-by: Chao Yu <yuchao0@huawei.com>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/f2fs/data.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/fs/f2fs/data.c
    +++ b/fs/f2fs/data.c
    @@ -456,6 +456,10 @@ int f2fs_submit_page_bio(struct f2fs_io_
    bio_put(bio);
    return -EFAULT;
    }
    +
    + if (fio->io_wbc && !is_read_io(fio->op))
    + wbc_account_io(fio->io_wbc, page, PAGE_SIZE);
    +
    bio_set_op_attrs(bio, fio->op, fio->op_flags);

    __submit_bio(fio->sbi, bio, fio->type);

    \
     
     \ /
      Last update: 2018-11-12 01:08    [W:4.040 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site