lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 357/361] net: sched: Remove TCA_OPTIONS from policy
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Ahern <dsahern@gmail.com>

    commit e72bde6b66299602087c8c2350d36a525e75d06e upstream.

    Marco reported an error with hfsc:
    root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
    Error: Attribute failed policy validation.

    Apparently a few implementations pass TCA_OPTIONS as a binary instead
    of nested attribute, so drop TCA_OPTIONS from the policy.

    Fixes: 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes")
    Reported-by: Marco Berizzi <pupilla@libero.it>
    Signed-off-by: David Ahern <dsahern@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/sched/sch_api.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/net/sched/sch_api.c
    +++ b/net/sched/sch_api.c
    @@ -1309,7 +1309,6 @@ check_loop_fn(struct Qdisc *q, unsigned

    const struct nla_policy rtm_tca_policy[TCA_MAX + 1] = {
    [TCA_KIND] = { .type = NLA_STRING },
    - [TCA_OPTIONS] = { .type = NLA_NESTED },
    [TCA_RATE] = { .type = NLA_BINARY,
    .len = sizeof(struct tc_estimator) },
    [TCA_STAB] = { .type = NLA_NESTED },

    \
     
     \ /
      Last update: 2018-11-12 00:46    [W:4.164 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site