lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 210/350] dmaengine: ppc4xx: fix off-by-one build failure
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christian Lamparter <chunkeey@gmail.com>

    commit 27d8d2d7a9b7eb05c4484b74b749eaee7b50b845 upstream.

    There are two poly_store, but one should have been poly_show.

    |adma.c:4382:16: error: conflicting types for 'poly_store'
    | static ssize_t poly_store(struct device_driver *dev, const char *buf,
    | ^~~~~~~~~~
    |adma.c:4363:16: note: previous definition of 'poly_store' was here
    | static ssize_t poly_store(struct device_driver *dev, char *buf)
    | ^~~~~~~~~~

    CC: stable@vger.kernel.org
    Fixes: 13efe1a05384 ("dmaengine: ppc4xx: remove DRIVER_ATTR() usage")
    Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/dma/ppc4xx/adma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/dma/ppc4xx/adma.c
    +++ b/drivers/dma/ppc4xx/adma.c
    @@ -4360,7 +4360,7 @@ static ssize_t enable_store(struct devic
    }
    static DRIVER_ATTR_RW(enable);

    -static ssize_t poly_store(struct device_driver *dev, char *buf)
    +static ssize_t poly_show(struct device_driver *dev, char *buf)
    {
    ssize_t size = 0;
    u32 reg;

    \
     
     \ /
      Last update: 2018-11-12 00:27    [W:4.069 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site